Repository navigation
chore(deps): bump actions/setup-java from 4 to 6 - #6012
Conversation
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4 to 6. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v4...v6) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
sunchao
left a comment
There was a problem hiding this comment.
Correctness
Reviewed 66e6fcf96bded979a9f2deae7488b7f5bf18416c against f51f5831b07e11a56e3d083e7c77b1395f53e715. This changes one call in publish_snapshot.yml: the snapshot deploy job moves from setup-java@v4 to v6 while continuing to request Zulu JDK 17. The other four Java setup call sites are unchanged.
The relevant runtime transition is Node 20 to Node 24, introduced in v5, with runner 2.327.1+ required. The changed job uses hosted ubuntu-24.04 without a job container. The Ubuntu 20.04 containers belong to the separate native-build job, whose libraries are downloaded as artifacts before packaging. There is no inherited container or self-hosted runner requirement here.
At the inspected v6 revision de7274f, Zulu resolves Linux x64 JDKs through the Azul Metadata API and verifies an authoritative download checksum when the package-details endpoint supplies one. The existing inputs remain supported. Java stays the default on PATH and in JAVA_HOME. The workflow writes its Nexus settings.xml after setup, so the action's initial Maven settings do not replace the publishing credentials. No GPG signing or action-managed dependency/JDK caching is requested. Maven 3.9.6 supports the new default MAVEN_ARGS=-ntp, which suppresses transfer progress.
No Comet expression, operator, fallback, or Spark profile changes. The maintained Spark 3.5/4.0 branch comparison has no changed SQL-semantic surface here. No Spark runtime compatibility result is claimed for any version.
Validation
YAML/source checks confirmed that the action reference is the only edit. Comet preflight ran the exact B/H merge b88d98e, whose tree equals the reviewed head, on runner 2.337.0. Its existing v6 Temurin 17 setup succeeded. Separately, the upstream Zulu 17 test checked out the same v6 revision, downloaded Zulu 17.0.20+8 on Ubuntu 24.04, and passed Java verification.
The PR currently has 10 successful and 30 skipped checks. Snapshot publishing is scheduled or manually dispatched and was not exercised by these PR runs. The upstream test supports the Java setup path, not Comet packaging or Nexus deployment. I found no introduced P1/P2 issue within this scope.
Performance
The change adds no work to Comet's query execution or native build. Zulu's new metadata and checksum lookup affects Java installation once per publishing job. Existing Maven repository and wrapper caches remain in use, and omitted cache/cache-jdk inputs do not enable duplicate action-managed caches. No installation-time or query-performance improvement is claimed, and no material regression is established by the inspected evidence.
Design
Updating the action at the deploy step keeps responsibility for Java installation with the existing dependency. The workflow retains JDK 17, the native artifact handoff, credential ordering, and its dry-run path. No additional wrapper or workflow restructuring is needed for the supported inputs and hosted runner.
Abstraction & complexity
This is a single dependency-reference change with no new abstraction, configuration branch, or duplicated setup logic. The existing composite builders remain outside the diff. I have no actionable simplification or compatibility change to request.
Bumps actions/setup-java from 4 to 6.
Release notes
Sourced from actions/setup-java's releases.
... (truncated)
Commits
de7274fAvoid macOS GPG socket overflow on long runner paths (#1266)134912aFix import-safe checks when scripts are run from a path with symlinks (#1265)0781fc6Fix alpine failures by switching default back to only warn on verification fa...4889c4aFix Temurin EA E2E signature verification (#1260)8fd3240[WIP] Fix failing GitHub Actions job for temurin 17 (#1259)2732291chore(deps-dev): update eslint and globals (#1256)1a8f22bchore: streamline Dependabot updates (#1255)85030b7docs: complete v6 release highlights (#1254)dd06d9cPrepare documentation for v6 release (#1253)59b3450chore(deps): combine open Dependabot npm updates (#1252)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)